Fix pressed keys reset when hiding a window on Windows#104802
Merged
Repiteo merged 1 commit intoNov 18, 2025
Merged
Conversation
Repiteo
added
the
cherrypick:4.5
bruvzg
approved these changes
Oct 7, 2025
Repiteo
force-pushed
the
fix-pressed-keys-resetted-when-hiding-window-on-windows
branch
from
e39f6d4 to
f323337
Compare
AThousandShips
changed the title
Contributor
|
Rebased to include @bruvzg's suggestion |
Contributor
|
Thanks! |
Member
|
Cherry-picked for 4.5.2. |
akien-mga
removed
the
cherrypick:4.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EnvironmentandSunto scene no longer works on 4.4 #104479The problem was introduced in #99010 to fix an issue where the user was unable to resize the floating window or use buttons in the editor when the embedded game was activated on Windows. Prior to #99010, the window needed to be focused in order to be resized using the mouse. The modification, however, introduced a side effect: it reset the pressed keys in
Inputwhen hiding a window, because deactivation was no longer handled by the timer.By retaining the timer solely for the deactivation process, the original issue remains resolved, and it also fixes #104479, as the pressed keys are no longer reset immediately when calling the
hidemethod on a window.